Groww-OSS / Groww-OSS/webster

ella: downloadFile method not working on safari ios

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5
Forks
10
PR merge metrics
No merged PRs in 30d

Description

We are creating an anchor tag and setting its target to `_blank` and we are performing click action via javascript. Safari on ios is assuming it as a popup and is blocking it, it works when `Block Popup` is turned off.
![Image from iOS](https://github.com/Groww-OSS/webster/assets/114666956/f7013d89-eeb3-4318-b7d5-8b36a6961728).
Can we add check for Safari to avoid `link.target='_blank`, and then the file will open on same tab. One issue with this solution is that, on ios Safari and Chrome have same userAgents so it will be difficult to differentiate between them.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.