GrenderG / GrenderG/mewdistro

The trainer ID randomization doesn't work, it's always 00001

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
19
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Both Mewdistro and Celebidistro don't give a randomized ID each time you trade or `make`.

Line 315 `pPartyMember->original_trainer_id = (randw() % 65535) + 1;` always resolves as 0 + 1, so the function is not working as expected. You can manually set the value you want by replacing 1 for the desired ID which is useful, but still code made me believe the original purpose was a randomized ID.

Also note that 00000 is a possible ID, so there is no need to give + 1 and just a number from 00000 to 65535 will be valid.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.