Greenstand / Greenstand/treetracker-admin-client

Use appropriate AWS credential to do the release

Open
#1,067 0 comments 0 reactions 1 assignee View on GitHub

@emmanue is already working on this.

Since Jul 9, 2023.

AWS devops terraform
Dominant language
JavaScript
Stars
36
Forks
212
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Greenstand/treetracker-admin-client/blob/6f2c57f3affd3fdf4d0b690d1be379044035e228/.github/workflows/build_and_release.yaml#L161-L163

In above code, we are using temporary secrets with too wide permission to do the s3 upload, we need use the correct ones :
AWS_SECRET
AWS_KEY_ID
AWS_KEY_ID_PROD (for prod env)
AWS_SECRET_PROD (for prod env)

The reason that we use temporary ones is because we need adjust the permission of these scretes above, check our terraform settings for this here:
https://github.com/Greenstand/treetracker-infrastructure/blob/fe6286893c467cc872afa5b7fbaf66d96107716e/aws_access/terraform/users.tf

In short, we need to replace the secrets with the name above, and make sure the github action is functional

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.