Graylog2 / Graylog2/graylog2-server

As an Admin User Access Tokens of other users can be viewed in Plain

Open
#9,124 5 comments 0 reactions 0 assignees View on GitHub
improvement security triaged
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

Dear Graylog Team,

we happiliy read the news about Graylog 3.3 with encrypted tokens https://docs.graylog.org/en/3.3/pages/upgrade/graylog-3.3.html#api-access-token-encryption . Our expection of this news, was that token are now handled similar to passwords. Unfortunely as an Admin one can see tokens of other users in Plaintext.

## Expected Behavior
Tokens are hashed and salted in MongoDB and can not be seen anywhere in plain after creation.

## Current Behavior
Tokens are visible in Plaintext although they give the same access as the users password.

## Possible Solution
Handle tokens as passwords and give only during creation of token the possiblity to read the token in plaintext.

Ideally a User gets an E-Mail if someone creates a token in his usercontext, so he can control if the creation is wanted, additionally it would be a nice feature if tokens could be bound only to specific functions in a usercontext e.g. execution of a specific search.

## Steps to Reproduce (for bugs)

1. Assign/create Token to/as User
2. Admin and User can see the token in Plaintext
3.
4.

## Context
Tokens should be treated as passwords and should have the same security regulations (salt and hash)

## Your Environment

* Graylog Version: 3.3
* Java Version: %
* Elasticsearch Version: %
* MongoDB Version: %
* Operating System: %
* Browser version: %

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.