Graylog2 / Graylog2/graylog2-server
ChainingClassLoader - problem with custom kafka plugin
- Dominant language
- Java
- Stars
- 8.1k
- Forks
- 1.1k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 217
Description
We created our custom kafka plugin, but using some custom fields, we would like to add SASL there and upgrade kafka dependencies for it, but we have problems with that and reason is that you are using ChainingClassLoader, which uses graylog own classloader+adds classes from plugin jar. As graylog already contains kafka input with old libraries, these are before custom plugin own updated kafka-libraries in classloader, so plugin loads old instead of new one.
https://github.com/Graylog2/graylog2-server/blob/20ab7325eb82ec09c08ece0433e183412f32a05d/graylog2-server/src/main/java/org/graylog2/shared/plugins/PluginLoader.java#L124
https://github.com/Graylog2/graylog2-server/blob/20ab7325eb82ec09c08ece0433e183412f32a05d/graylog2-server/src/main/java/org/graylog2/shared/plugins/PluginLoader.java#L55
Best solution would be probably make all inputs plugins
Contributor guide
Assessment
This issue has not been assessed yet.