Graylog2 / Graylog2/graylog2-server

Add an explicit interface for calls from outside the `views` package

Open
#7,459 0 comments 0 reactions 0 assignees View on GitHub
improvement search
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

Currently it's not immediately clear what other parts of the system depend on views.
Adding an explicit interface should
- simplify changes behind the interface
- simplify things for consumers, because right now they can reuse individual parts (like ViewsService) and then have to deal with our data structures themselves. => Repeated logic, subtle bugs (because the intricacies of the views system might not be intuitive for everyone), and very tight coupling.

If the called functionality is generic, the interface could be defined in views. If not, it might make more sense to define multiple interfaces on the side of consumers and make views implement them

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.