Graylog2 / Graylog2/graylog2-server

Click on legend offers editing color when not in edit mode

Open
#7,394 0 comments 0 reactions 0 assignees View on GitHub
bug High Prio search
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

## Expected Behavior
Clicking on a legend item should toggle or highlight the corresponding visualization item.

## Current Behavior
Click a legend item offers to edit the color of the series, which I would only expect in the "Edit" mode of the widget (where it appears, so that's good!).
I think it's inconsistent to allow editing the series color where almost everything else is read-only.
![image](https://user-images.githubusercontent.com/52014/73832801-1f953880-4809-11ea-86cb-24d51aa2f846.png)

## Possible Solution
Change the legend on-click behavior to toggling the series instead of showing the color editor when the widget is not in edit mode.

## Steps to Reproduce (for bugs)
Obvious from the screenshot.

## Context
Other products often allow toggling or highlighting a series based on the legend item, so Graylog is surprising here.
For consistency, I think we also shouldn't allow editing visualization elements if not in edit mode.

## Your Environment

* Graylog Version: 3.2.1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.