Graylog2 / Graylog2/graylog2-server

Improvements in duplicated content pack error message

Open
#5,581 0 comments 0 reactions 0 assignees View on GitHub
content-packs improvement triaged
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

## Description
Improve error notification when uploading a duplicated content pack by:

- Making error message clearer
Currently the error message states that it may not be valid JSON, and later adds some more details where one can see that the ID is already used. Separating the cases where the upload is not a valid JSON document and other errors would already help. Resolving the name attached to that ID would be even better.

- Remove escaped HTML tags from error message
In #4726 we enabled by default HTML escape on toastr to fix some XSS issues we had. Until we switch to another library to render user notifications, we should avoid using HTML in the notifications.

![screenshot 2019-01-23 at 12 24 20](https://user-images.githubusercontent.com/716185/51617123-da6ad500-1f2b-11e9-9aea-77930b79f71f.png)

## Your Environment
* Graylog Version: Graylog 3.0.0-beta.4-SNAPSHOT (87afab1)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.