Graylog2 / Graylog2/graylog2-server

Don't sort output config fields by optionality

Open
#4,761 4 comments 0 reactions 0 assignees View on GitHub
good first issue papercut triaged
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

## Expected Behavior

The config fields of my output plugin appear in the order I registered them.

## Current Behavior

If some of them are optional, they are shown below all others.

## Possible Solution

Don't [sort the fields by optionality](https://github.com/Graylog2/graylog2-server/blob/eec520f92acfe69ed6bc86b1bb259bfe07cc59de/graylog2-web-interface/src/components/configurationforms/ConfigurationForm.jsx#L156).

## Steps to Reproduce (for bugs)

Register two output config fields and make the first optional.

## Context

https://github.com/Graylog2/graylog2-server/pull/4746#issuecomment-384253076

## Your Environment

(not relevant)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.