Graylog2 / Graylog2/graylog2-server

LookupCache shouldn't call entryCount() before cache was started

Open
#4,535 1 comment 0 reactions 0 assignees View on GitHub
bug triaged
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

`LookupCache` should call `LookupCache#entryCount()` before the cache was actually started.

When using a remote data source which isn't available until `LookupCache#doStart()` has been called, `LookupCache#entryCount()` might not return a sensible value or even throw an exception (e. g. because the connection to the remote data source hasn't been established yet).

https://github.com/Graylog2/graylog2-server/blob/2c418975989da2fff589e35cdf8c00ff41983e52/graylog2-server/src/main/java/org/graylog2/plugin/lookup/LookupCache.java#L63

## Expected Behavior

Don't call `LookupCache#entryCount()` before cache has been initialized via `LookupCache#doStart()`.

## Current Behavior

The `LookupCache` constructor calls `LookupCache#entryCount()` before `LookupCache#doStart()` has been executed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.