Graylog2 / Graylog2/graylog2-server

Use stronger types for transaction marker payloads and activity details

Open
#25,547 0 comments 0 reactions 0 assignees View on GitHub
collector
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

Transaction markers have a payload of type `Document` [here](https://github.com/Graylog2/graylog2-server/blob/ff189e3589b833e3d921b7711527dd5ac8824865/graylog2-server/src/main/java/org/graylog/collectors/db/TransactionMarker.java#L44).

Activity details reflect that by using `Map` [here](https://github.com/Graylog2/graylog2-server/blob/master/graylog2-server/src/main/java/org/graylog/collectors/rest/RecentActivityResponse.java#L35)

We usually try to avoid that and use proper Jackson subtypes with type discriminators to model this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.