Graylog2 / Graylog2/graylog2-server

Allow all node.attr.* attributes for Data Node OpenSearch overrides

Open
#24,014 0 comments 0 reactions 0 assignees View on GitHub
feature
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

## What?

OpenSearch has allows arbitrary attributes configured via `node.attr.*` properties.

Our [current allow list](https://github.com/Graylog2/graylog2-server/blob/91150bd211f9dfe9e8e279054ce83915f29c78f4/data-node/src/main/java/org/graylog/datanode/opensearch/configuration/beans/impl/OpensearchConfigurationOverridesBean.java#L51-L57) is only allowlisting `node.attr.zone`.

Can this be expanded to `^node\\.attr\\..*$` ?

## Why?

Some features of OpenSearch, such as [Shard allocation filtering](https://docs.opensearch.org/latest/api-reference/index-apis/shard-allocation/) rely on node attributes. It is also common for OpenSearch administrators to define attributes that allow differentiating nodes.

## Your Environment

* OpenSearch Version: Data Node

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.