Graylog2 / Graylog2/graylog2-server

Unify default value handling for JSON-Schema generator

Open
#23,912 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

We started using victools-jsonschema-generator and have a custom default value handler.
It's currently also pulling in jakarta.ws.rs annotations, which we might not want to require.

This is a follow-on task.

Original comment:
I mostly added because it felt weird having jakarta annotations for validations (to include in the json schema), such as `@Positive`, as their standalone annotations, but the default value for a property was buried somewhere in the `@JsonProperty` annotation. I don't feel strongly about keeping this, though, it's just a handful of places which can be covered with the jackson annotation property.

_Originally posted by @kroepke in https://github.com/Graylog2/graylog2-server/pull/23462#discussion_r2429831533_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.