Graylog2 / Graylog2/graylog2-server

Improve event definition disable/enable toggle when editing an event definition

Open
#19,427 0 comments 0 reactions 0 assignees View on GitHub
feature secdev-cycle5 triaged
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

## What?

When editing an event definition, the placement and wording to disable/enable the event definition should be improved to match the intuitive nature of the `Status` column on the `Event Definitions` page (`/alerts/definitions`).

## Why?

When looking at the `Status` column on the `Event Definitions` page, it's extremely easy to determine the current status of the event definitions, and equally as easy to toggle their state.
![image](https://github.com/Graylog2/graylog2-server/assets/19417721/5e04fb00-cc2a-4214-a197-48c4eb7712e0)
![image](https://github.com/Graylog2/graylog2-server/assets/19417721/33aecc81-c08b-49d2-968c-d9f6026737a7)

In comparison, when editing an event definition you have to:
1. Look for the checkbox input in the `Condition` section (e.g. `Filter & Aggregation`).
2. Understand that the `Enable` checkbox and `Should this event definition be executed automatically?` correlate to the event definition being disabled/enabled. AFAIK event definitions can't be manually executed, which could make one wonder if this was the disabled/enabled toggle. Easy enough to figure out, but could be made more consistent.
![image](https://github.com/Graylog2/graylog2-server/assets/19417721/80f53aa9-6e47-44f9-9191-ab6983c1276e)
4. Understand that `Enable scheduling` in the summary correlates to the event definition being disabled/enabled.
![image](https://github.com/Graylog2/graylog2-server/assets/19417721/cfec7b9b-77a8-4dbb-8856-952017017f9e)

Work with Graylog enough and you'll figure this stuff out, but a new user might get a bit confused.

## Your Environment

* Graylog Version: `6.0.1`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.