Graylog2 / Graylog2/graylog2-server

Should ContentPackService#listAllEntityExcerpts fail on error with single Entity?

Open
#18,035 0 comments 0 reactions 0 assignees View on GitHub
bug needs-discussion triaged
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

## Expected Behavior
When single entity, accessible by single entity facade, has problem (i.e. malformed entity was stored in Mongo DB), we should probably not fail completely the call to ContentPackService#listAllEntityExcerpts, but rather return limited list, with successfully created entities.
(may need discussion)

## Current Behavior
ContentPackService#listAllEntityExcerpts fails as a whole.
Functionality using this method fails as well (i.e. start page elements).

## Possible Solution
Not fail completely the call to ContentPackService#listAllEntityExcerpts, but rather return limited list, with successfully created entities.
Catch exceptions and react to them.

## Steps to Reproduce (for bugs)
One of the examples - HS-2290625939

## Context
HS-2290625939

## Your Environment
* Graylog Version: 5.2.3

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.