Graylog2 / Graylog2/graylog2-server
Setting the leader in the Configuration in the Server class at runtime
Open
bug
triaged
- Dominant language
- Java
- Stars
- 8.1k
- Forks
- 1.1k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 217
Description
## Current Behavior
https://github.com/Graylog2/graylog2-server/blob/596b03094601826e7c1430bbcebe0a7bb3472073/graylog2-server/src/main/java/org/graylog2/commands/Server.java#L278
changes the configuration at Runtime. I think there are two problems with this:
- first, I think the Configuration classes should be immutable
- second, this change in configuration clashes with the current way of leader-election via the service which, IMHO should only be derived from runtime state in the Leader Election classes (which was probably initialised from the configuration on startup)
Contributor guide
Assessment
This issue has not been assessed yet.