Graylog2 / Graylog2/graylog2-server

Rename "DSV File from HTTP" adapter to "CSV File from HTTP"

Open
#14,120 1 comment 0 reactions 0 assignees View on GitHub
feature triaged
Dominant language
Java
Stars
8.1k
Forks
1.1k
Avg merge
1d 20h
Merged PRs (30d)
217

Description

## What?

Rename "DSV File from HTTP" adapter to "CSV File from HTTP".

## Why?

There is a huge overlap in functionality between our _CSV_ adapters and the _DSV File from HTTP Adapter_ (see screenshots).

The only difference (besides the HTTP fetching) seems to be the _Check Presence Only_ option.

I think CSV is the far more common term, and therefore I would suggest to rename the adapter to bring it closer to the other CSV ones.

We could also think about adding the _Check Presence Only_ field to all CSV adapters, but that could be a separate issue.

Please note that my suggestion is coming mostly from the end user perspective (regarding the naming of the adpater in the UI, and documentation). The change should not break any existing DSV adapter configurations.

Screenshot 2022-12-02 at 09 43 14
Screenshot 2022-12-02 at 09 43 26
Screenshot 2022-12-02 at 09 44 18

## Your Environment

* Graylog Version: 5.0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.