Graylog2 / Graylog2/graylog2-server
Improve Database Services That Extend PaginatedDbService
- Dominant language
- Java
- Stars
- 8.1k
- Forks
- 1.1k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 217
Description
## What?
In the changes to add `ScopedEntities`, Database Service classes were updated to extend `PaginatedDbService`. Some of these services already implement methods like (or exactly the same) as the paginated database service. These services should be updated such that duplicated code is removed.
If a service requires special handling in addition to the database operation, the super class method should be called before/after performing the spacial handling. For example, some services perform validation then perform a save operation. Such a service can perform then validation then call the PaginatedDbService::save method.
The database services that need to be updated are:
1. DBLookupTableService
2. DBCacheService
3. DBDataAdapterService
## Why?
## Your Environment
* Graylog Version:
* Elasticsearch Version:
* MongoDB Version:
* Operating System:
* Browser version:
Contributor guide
Assessment
This issue has not been assessed yet.