Graylog2 / Graylog2/graylog-plugin-integrations

Slack Plugin - Code Refactoring

Open
#611 1 comment 0 reactions 0 assignees View on GitHub
improvement needs-discussion
Dominant language
Java
Stars
17
Forks
14
PR merge metrics
No merged PRs in 30d

Description

1. execute method remove the call for validate method.
2. Slack client needs its own SlackClientException similar to PagerDutyClientException.
3. Update junit tests accordingly.
4. update severity of notifications, Urgent vs Normal

**Reference**
Config validation happens when a user creates/modifies a Notification from the UI. It should not be possible for invalid config to exist at this point in processing.
```suggestion
```

_Originally posted by @waab76 in https://github.com/Graylog2/graylog-plugin-integrations/pull/595#discussion_r512238987_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.