Graylog2 / Graylog2/collector

Supervisor should send agent_disconnect message on shutdown

Open
#85 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1
Forks
0
Avg merge
3d 1h
Merged PRs (30d)
7

Description

Currently the server needs to rely on the online threshold expiring to show a disconnected collector in its actual state.

If we send the agent_disconnect message (which the library might already do) and handle it server side, we can immediately reflect this in its status.

See https://opentelemetry.io/docs/specs/opamp/#agenttoserveragent_disconnect

Contributor guide

Open the contributing guide

Research direction

Start at the Supervisor shutdown path and trace how the server currently determines collector connectivity. Check whether the library already emits the OpAMP agent_disconnect message, then follow the server-side handling of that message. Done means a shutting-down collector is reflected as disconnected immediately instead of waiting for the online threshold to expire.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.