GraphiteEditor / GraphiteEditor/Graphite

Stable element IDs instead of indexes in the graph

Open
#1,821 1 comment 0 reactions 0 assignees View on GitHub
Architecture Graphene
Dominant language
Rust
Stars
27.2k
Forks
1.3k
Avg merge
20h 5m
Merged PRs (30d)
57

Description

In order to apply the Path node's vector modification on `Table` data, it is necessary to be able to identify which row it targets.

We could do this by index (e.g. modification to row 3 within the graphic table). However @Keavon wants to allow nodes to rearrange the table rows without impacting the result.

In order to do this, each row will have an id assigned when creating it. Nodes will be able to get their own id by having the input `TaggedValue::MyNodeId` (which would be populated during graph pre-processing). In order to avoid cutting and pasting changing the node id (as it does currently) some more logic to check if no such id exists will be added.

Each graphic table must contain unique ids. It is the job of the constructing node to enforce this (e.g. incrementing one of the ids to avoid collision).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.