GrapesJS / GrapesJS/grapesjs

BUG: Modals close on mouseup event outside of modal rather than a full click

Open
#6,683 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
26.2k
Forks
4.6k
Avg merge
2d 21h
Merged PRs (30d)
6

Description

### GrapesJS version

- [x] I confirm to use the latest version of GrapesJS

### What browser are you using?

Chrome 143.0.7499.169

### Reproducible demo link

https://grapesjs.com/demo.html

### Describe the bug

**How to reproduce the bug?**
1. Drag a custom code component into the page.
2. The modal should open automatically, else double click the custom code component in the preview.
3. Click and hold inside the modal then drag your mouse outside the modal and release the click.
4. The modal closes.

**What is the expected behavior?**
Seems to me the modal should only close on a full click event outside the modal.

**What is the current behavior?**
The modal seems to be closing on just a mouseup event.

I took a look in the modal files and don't see a quick answer of why this is happening. The modal events all seems to be 'click' events... or at least they are labelled as such.

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.