GradleUp / GradleUp/tapmoc

Tapmoc ignores `kotlin.stdlib.default.dependency=false` in a sub-project's gradle.properties

Open Beginner friendly
#101 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
109
Forks
6
Avg merge
11m
Merged PRs (30d)
3

Description

When setting kotlin.stdlib.default.dependency=false in a non-root Gradle project, Tapmoc nevertheless adds the stdlib to the project dependencies. This is undesirable when creating a shadow Jar in one sub-project and the stdlib dependency should be disabled just there.

This code honors the root project's gradle.properties only:

https://github.com/GradleUp/tapmoc/blob/be675d7d8564b637b4245b96bca5a1928da29dcb/tapmoc-gradle-plugin/src/kgp/kotlin/tapmoc/internal/KgpImpl.kt#L104-L107

Replacing it with the following code would make it work for root and non-root gradle.properties:

val isStdlibDefaultDependencyEnabled =
    project.findProperty("kotlin.stdlib.default.dependency")?.toString()?.toBooleanStrictOrNull() != false

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in tapmoc-gradle-plugin/src/kgp/kotlin/tapmoc/internal/KgpImpl.kt around lines 104-107, where the root project's property is read. Verify how project.findProperty behaves for root and non-root Gradle projects, then confirm the setting is honored in a sub-project while existing root-project behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.