Gozala / Gozala/channel

DroppingBuffer is broken

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
36
Forks
3
PR merge metrics
No merged PRs in 30d

Description

DroppingBuffer seems to inherit the prototype from itself, which breaks its functionality (e.g. Channel.output.put produces an error). I have fixed it as follows:

buffer.js : line 64:

```
DroppingBuffer.prototype = Object.create(DroppingBuffer.prototype)
```

should be

```
DroppingBuffer.prototype = Object.create(UnblockingBuffer.prototype)
```

I wasn't sure if this should be a pull request or not, so I decided to report it instead.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.