GothenburgBitFactory / GothenburgBitFactory/timewarrior

Faulty config can be inserted, then renders everything unusable

Open
#226 1 comment 0 reactions 0 assignees View on GitHub
bug enhancement
Dominant language
C++
Stars
1.7k
Forks
117
Avg merge
1d 7h
Merged PRs (30d)
5

Description

When trying to follow the tutorial, the following commands (note the typo, I used `-` instead of `_`) rendered timew completely unusable for me, I had to manually edit the config:

```
$ python --version
Python 2.7.15rc1
$ timew --version
1.0.0
$ timew config exclusions.days.2019-05-29 off
Are you sure you want to add 'exclusions.days.2019-05-29' with a value of 'off'? (yes/no) yes
Config file /home/daniel/.timewarrior/timewarrior.cfg modified.
$ timew --help
Unrecognized construct: exclusions.days.2019-05-29 = off
```
IMHO, timew should disallow setting configuration via the commandline that makes the commandline unusable.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the documented `timew config exclusions.days.2019-05-29 off` command and then `timew --help` with the resulting configuration. Trace the command-line configuration handling and make the invalid setting fail before the config is written; done means the command remains usable after rejected input.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.