GothenburgBitFactory / GothenburgBitFactory/timewarrior

"exclusions.days... = off" does not work as expected

Open
#199 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
1.7k
Forks
117
Avg merge
1d 7h
Merged PRs (30d)
5

Description

When using `timew config exclusions.days.2018_12_25 off` I expected it will disable any other exclusion for the given day, i.e. holidays and/or "work week" exclusions. But it does not do it and reports still show a day as excluded.

Here is example config:
```
~/timewarrior_test/ ❯ cat timewarrior.cfg
define holidays:
test:
2018_12_25 = test holiday

exclusions.days.2018_12_25 = off
```
And I got this in `timew week` report:
![image](https://user-images.githubusercontent.com/100994/50539720-f9c54b00-0b95-11e9-96fd-a31f515dc513.png)

Here is another example:
```
~/timewarrior_test/ ❯ cat timewarrior.cfg
define exclusions:
tuesday = >00:00

exclusions.days.2018_12_25 = off
```

And here is the result:
![image](https://user-images.githubusercontent.com/100994/50539736-4741b800-0b96-11e9-966a-ee26d209332c.png)

```
~/timewarrior_test/ ❯ timew diag

timew 1.1.1
Platform: Darwin

Compiler:
Version: 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.10.43.1)
Caps: +stdc +stdc_hosted +LP64 +c8 +i32 +l64 +vp64 +time_t64
Compliance: C++11

Build Features
Built: Aug 24 2018 12:09:29
CMake: 3.12.1
Build type: Release

Configuration
TIMEWARRIORDB: /Users/alex/timewarrior_test/
Cfg: /Users/alex/timewarrior_test//timewarrior.cfg (-rw- 72 bytes)
Database: /Users/alex/timewarrior_test/ (drwx 160 bytes)
$EDITOR: vim
Color theme: Built-in default
00 01 02 03 04 05 06 07 08 09 10 11 12

Extensions
Location: /Users/alex/timewarrior_test//extensions (drwx 64 bytes)
(None)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.