GothenburgBitFactory / GothenburgBitFactory/taskwarrior

[TW-1727] Overzealous alias expansion

Open
#1,751 8 comments 2 reactions 0 assignees View on GitHub
type:bug
Dominant language
C++
Stars
6.1k
Forks
423
Avg merge
1d 19h
Merged PRs (30d)
11

Description

_Daniel Shahaf on 2015-11-18T21:24:42Z says:_

```
% task add find a shell at the beach
Created task 1.
% task _get 1.description
find a exec tasksh at the beach
```

The word `shell` should not have been subjected to alias expansion, since aliases are for commands only (according to `taskrc(5)`) and the command is `add`.

Yes, using a `--` guard inhibits alias expansion, but that is not a solution because a user might call `task add foo bar` without realizing that one of the words in his command line is a configured alias: from that user's perspective, `task` will have silently corrupted his input. (That's what happened to me, and only thanks to keeping ~/.task in git could I restore the original task description I had added.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.