Request: Respect lang when linking extensions
Nobody has claimed this yet.
- Dominant language
- Dart
- Stars
- 26.4k
- Forks
- 1.7k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 50
Description
Description
Chinese lang is linked to on the firefox addon store independent of which language is set.
I've only observed this issue when linking to the firefox addon store.
https://github.com/GopeedLab/gopeed/blob/1d86d14a209ddc6a4a713459e67ecf0af07d0ca9/ui/flutter/lib/app/modules/setting/views/setting_view.dart#L155
Note
Firefox doesn't seem to respect browser language either when visiting the extension without a preference and just defaults to english:
https://addons.mozilla.org/firefox/addon/gopeed-extension/
App Version
1.6.0
OS Version
Arch Linux
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ui/flutter/lib/app/modules/setting/views/setting_view.dart around line 155, where the Firefox Add-ons link is assembled. Check how the current language setting is available to that view and compare the generated link with the Firefox Add-ons URL. Done means the link respects the selected language, with the behavior verified for Chinese and another language.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- dart, flutter
- Domain
- localization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100