GoogleContainerTools / GoogleContainerTools/skaffold

skaffold verify should exit with non-zero code when aborted by signal

Open
#9,800 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

When a run of `skaffold verify` is aborted by signal, it returns an exit code of `0`, indicating success.

This is problematic when using `skaffold verify` for testing in CI, because it will indicate that tests passed, when they did not.

`skaffold verify` should exit with a non-zero exit code when aborted by signal to indicate that tests did not pass.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.