GoogleContainerTools / GoogleContainerTools/skaffold
Skaffold deploy not passing flags to Helm
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
I have tried the following variations to send the `--history-max 1` flag to Helm:
```yaml
deploy:
helm:
releases:
- name: my-app
flags:
upgrade: ["--history-max", "1"]
```
```yaml
deploy:
helm:
releases:
- name: my-app
flags:
upgrade: ["--history-max=1"]
```
```yaml
deploy:
helm:
releases:
- name: my-app
flags:
upgrade:
- "--history-max=1"
```
However, Skaffold ignores this option:
`Running command: [helm --kube-context gke_gcp-my-cluster-dev upgrade my-app skaffold/helm --post-renderer /usr/bin/skaffold --namespace test -f skaffold/helm/values/globals.yml -f skaffold/helm/values/values-dev.yml]`
What is the correct way to pass flags to Helm upgrade?
Contributor guide
Assessment
This issue has not been assessed yet.