GoogleContainerTools / GoogleContainerTools/skaffold

Support set-json for helm

Open
#9,112 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

Skaffold uses a very magicy yaml library.
This makes it often very hard/impossible to pass boolean/numeric values to helm as a strings.

Supporting passing raw (uninterpreted) json values to `helm` via `--set-json` should fix that.

And example could be:

```yaml
manifests:
helm:
releases:
- name: foo
setJsonValues: {port: "345"}
```

This of course only works if one can force the yaml library to handle values of `setJsonValues` always as strings.
Alternatively one could add an escape hatch via a release-specific `flags`:

```yaml
manifests:
helm:
releases:
- name: foo
flags:
- --set-json={"port": "345"}

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.