GoogleContainerTools / GoogleContainerTools/skaffold

Assign NULL in deploy.helm.releases.[0].setValueTemplates

Open
#9,066 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior
I wanted to use `skaffold dev`, after temporarily removing some defaults in the Helm template.
(e.g. `nodeSelector`)

In the skaffold.yaml below,
Expected behavior is that the nodeSelector statement is deleted, when `null` or `{}` is assigned to `deploy.helm.releases.[0].setValueTemplates.nodeSelector`.

### Actual behavior
`"null"`, `""` works correctly
`null`, `{}`, `"{}"` doesn't work

### Information

- Skaffold version: v2.6.0-1-gb25a5ed52
- Operating system: Ubuntu 22 LTS
- Installed via: Cloud Code
- Contents of skaffold.yaml:
```yaml
# my helm template
(...)

{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{- end }}

(...)
```

```yaml
# my default helm values
(...)
nodeSelector:
my-node: worker
(...)
```
```yaml
# skaffold.yaml
(...)
- name: alpha
patches:
- op: add
path: /deploy/helm/releases
value:
- name: my-release
(...)
setValueTemplates:
nodeSelector: "null" # PASS: "null", "" # FAIL: {}, "{}", null
(...)
```

### P.S.
- Is this the original intended feature of skaffold?
- If you know related docs or issue numbers, please let me know.
Thank you

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.