GoogleContainerTools / GoogleContainerTools/skaffold

Allow templating for `requires[].git.repo`

Open
#8,982 1 comment 3 reactions 0 assignees View on GitHub
area/templating kind/todo meta/triage priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior
Templating should work for `requires[].git.repo`. This field doesn't seem to support templating, as outlined in the docs: https://skaffold.dev/docs/environment/templating/. This is required to access a remote private git repository from a CI pipeline.

### Actual behavior
Templating does not work for `requires[].git.repo`

### Information

- Skaffold version: v2.4.0
- Operating system: Ubuntu 22.04.1
- Installed via: Standalone binary
- Contents of skaffold.yaml:

```yaml
---
apiVersion: skaffold/v4beta4
kind: Config
metadata:
name: my-config

requires:
- configs:
- my-remote-config
git:
repo: "https://{{.PAT}}@dev.azure.com/my-org/my-project/_git/my-remote-repo"
path: skaffold.yaml
sync: true
ref: develop
```

### Steps to reproduce the behavior

1. Store a skaffold config in a remote repository
2. Run `skaffold run -m kafka` while passing in a PAT env var for your repo
3. See that skaffold is not able to resolve the templated value

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.