GoogleContainerTools / GoogleContainerTools/skaffold
Improve/fix load Image logic in deployers, related with Kind and K3D
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
When running `skaffold dev` in a project with multiple modules, each pointing to different local clusters (Kind and/or K3D), Skaffold will try load all the images, from all the modules, in all the clusters, this is not needed.
We should load only the proper images in each cluster, that means, only the images detected in the module for each context.
Looks like the problem relies in the way we are calculating the images to load, for instance:
https://github.com/GoogleContainerTools/skaffold/blob/a3ee2cc2254181ff375e29da7ab60ef8e23174b8/pkg/skaffold/deploy/kubectl/kubectl.go#L116-L122
The `artifacts` variable, used to calculate the original images (`ogImages`) slice, is populated using the values from all the images in all the pipelines.
For more context about this issue, [check this comment](https://github.com/GoogleContainerTools/skaffold/pull/8935#discussion_r1262812712).
### Information
- Skaffold version: 2.6.0
Skaffold yaml file for repoduction: Pending
Contributor guide
Assessment
This issue has not been assessed yet.