GoogleContainerTools / GoogleContainerTools/skaffold

Schema version when doing a patch release doesn't match with the one already live

Open
#8,795 0 comments 0 reactions 0 assignees View on GitHub
kind/friction meta/release priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

Currently, the linter tests in PRs against a Skaffold version different that the one already live, with a schema version different than the latest one, are failing.

This is because we are using the information in the latest GCS regardless of the version we are targeting. The code can be followed from here: https://github.com/GoogleContainerTools/skaffold/blob/44a5904427f8b785e60c71a71c17dfa8b48d00ef/hack/versions/cmd/latest_released/version.go#L32

Linter error example:
```
Running validation scripts...
RUN hack/check-schema-changes.sh
PASSED hack/check-schema-changes.sh in 2s
RUN hack/check-samples.sh
examples/buildpacks-node-tutorial doesn't have a skaffold.yaml!
examples/jaeger-skaffold-trace doesn't have a skaffold.yaml!
examples/jib-sync doesn't have a skaffold.yaml!
skaffold version in examples/gcb-kaniko/skaffold.yaml should be skaffold/v4beta[5](https://github.com/GoogleContainerTools/skaffold/actions/runs/4930438712/jobs/8811617462?pr=8761#step:5:6)
skaffold version in examples/jib/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/microservices/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/helm-render/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/getting-started-kustomize/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/profiles/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/buildpacks-node/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/multi-config-microservices/leeroy-app/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/multi-config-microservices/leeroy-web/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/multi-config-microservices/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/multi-config-microservices/base/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/buildpacks-java/skaffold.yaml should be skaffold/v4beta5
skaffold version in examples/simple-artifact-dependency/skaffold.yaml should be skaffold/v4beta5
...
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.