GoogleContainerTools / GoogleContainerTools/skaffold

Remove field `manifests.helm.releases[].createNamespace` and instead suggest users to use `deploy.helm.releases[].createNamespace`

Open
#8,533 1 comment 0 reactions 0 assignees View on GitHub
area/schemas deploy/helm kind/todo priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

After Skaffold v2, the original helm deploy schema configuration was duplicated into `manifests.helm` and `deploy.helm` locations. Some fields do not make sense in both location though, specifically `manifests.helm.releases[].createNamespace` does not make sense to have in `render` config has no resources are expected to be created there (just manifest creation) (this is currently not working as well, see - https://github.com/GoogleContainerTools/skaffold/issues/8515). `deploy.helm.releases[].createNamespace` currently works as intended though and is the correct place for this

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.