GoogleContainerTools / GoogleContainerTools/skaffold

Add support for `helm template` flags

Open
#8,439 3 comments 2 reactions 0 assignees View on GitHub
deploy/helm kind/feature-request priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior

There does not seem to be a way to pass `--no-hooks` to helm releases.

Being able to pass this flag to [helm template](https://helm.sh/docs/helm/helm_template/) would make renders (and therefore `kubectl diff`) much more readable.

For example, support for template flags may help:

```yaml
deploy:
helm:
flags:
template: ["--no-hooks"]
```

### Actual behavior

`skaffold render` uses `helm template` and all hooks are displayed.

### Information

- Skaffold version: 2.1.0
- Operating system: macOS 13.2
- Installed via: Nix
- Contents of skaffold.yaml:

```yaml
apiVersion: skaffold/v3
kind: Config
metadata:
name: third-party
deploy:
helm:
flags:
upgrade: ["--atomic"]
releases:
- name: prometheus
repo: https://prometheus-community.github.io/helm-charts
remoteChart: kube-prometheus-stack
version: 45.0.0
namespace: monitoring
createNamespace: true
wait: true
upgradeOnChange: true
```

### Steps to reproduce the behavior

1. Use skaffold.yaml above.
2. `skaffold deploy`
3. `skaffold render | kubectl diff -f -`
4. Resources from helm hooks (such as Batch jobs) show up in every diff

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.