GoogleContainerTools / GoogleContainerTools/skaffold

[docs/examples] update examples/helm-deployment (and other examples if needed) to reflect setValueTemplates preference (vs setValues)

Open
#8,313 0 comments 0 reactions 0 assignees View on GitHub
area/example deploy/helm kind/todo
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

Issues tracks updates examples/helm-deployment (and other examples if needed) to reflect setValueTemplates preference (vs setValues). Currentlyt the example has the following `skaffold.yaml`:
```
apiVersion: skaffold/v4beta1
kind: Config
build:
artifacts:
- image: skaffold-helm
deploy:
helm:
releases:
- name: skaffold-helm
chartPath: charts
setValues:
image: skaffold-helm
```

This is confusing as it seems to suggest `setValues` usage for image subst. which is not correct to do (causes errors w/ multiple images). It should instead be:
```
apiVersion: skaffold/v4beta1
kind: Config
build:
artifacts:
- image: skaffold-helm
deploy:
helm:
releases:
- name: skaffold-helm
chartPath: charts
setValueTemplates:
image: {{.IMAGE_FULLY_QUALIFIED_skaffold_helm}}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.