GoogleContainerTools / GoogleContainerTools/skaffold
Skaffold renders secrets incorrectly when there are multiple resources defined in a single yaml
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
### Expected behavior
skaffold render
```
apiVersion: v1
kind: Secret
metadata:
name: super-secret-secret
namespace: test
data:
password: c3VwZXJzZWN1cmVwYXNzd29yZA
---
apiVersion: v1
kind: Pod
metadata:
namespace: default
```
### Actual behavior
skaffold render
```
apiVersion: v1
kind: Secret
metadata:
name: super-secret-secret
namespace: test
--- <-----------Inserts document in between the secret
data:
password: c3VwZXJzZWN1cmVwYXNzd29yZA
---
apiVersion: v1
kind: Pod
metadata:
namespace: default
```
### Information
- Skaffold version: v2.0.4
- Operating system: Windows 11 Pro 22H2 22621.963
- Installed via: skaffold.dev
- Contents of skaffold.yaml:
```yaml
apiVersion: skaffold/v4beta1
kind: Config
metadata:
name: test-skaffold
manifests:
rawYaml:
- .\manifest.yaml
```
### Steps to reproduce the behavior
manifest.yaml:
```
apiVersion: v1
kind: Secret
metadata:
name: super-secret-secret
namespace: test
data:
password: c3VwZXJzZWN1cmVwYXNzd29yZA
---
apiVersion: v1
kind: Pod
```
1. skaffold render
```
PS > skaffold render -vdebug
time="2023-01-04T23:50:04-06:00" level=debug msg="skaffold API not starting as it's not requested" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=info msg="Skaffold &{Version:v2.0.4 ConfigVersion:skaffold/v4beta1 GitVersion: GitCommit:01dd5065e6c1f91b046edef95074e68050a9c28c BuildDate:2022-12-21T09:13:48Z GoVersion:go1.19.1 Compiler:gc Platform:windows/amd64 User:}" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Disable housekeeping messages for command explicitly" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="parsed 1 configs from configuration file C:\\Users\\waj33\\test-skaffold\\skaffold.yaml" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Defaulting build type to local build" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Found raw k8s manifests without cloud run deploy, adding kubectl deployer" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=info msg="Using kubectl context: docker-desktop" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=info msg="Loaded Skaffold defaults from \"C:\\\\Users\\\\waj33\\\\.skaffold\\\\config\"" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="getting client config for kubeContext: `docker-desktop`" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="getting client config for kubeContext: `docker-desktop`" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Running command: [minikube version --output=json]" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Command output: [{\"commit\":\"986b1ebd987211ed16f8cc10aed7d2c42fc8392f\",\"minikubeVersion\":\"v1.28.0\"}\n]" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Running command: [C:\\Program Files\\Kubernetes\\Minikube\\minikube.exe profile list -o json --user=skaffold]" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Command output: [{\"invalid\":[],\"valid\":[]}]" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="setting Docker user agent to skaffold-v2.0.4" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=info msg="no kpt renderer or deployer found, skipping hydrated-dir creation" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Running command: [kubectl config view --minify -o jsonpath='{..namespace}']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Command output: ['']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:04-06:00" level=debug msg="Running command: [kubectl config view --minify -o jsonpath='{..namespace}']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Command output: ['']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Running command: [kubectl config view --minify -o jsonpath='{..namespace}']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Command output: ['']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Running command: [kubectl config view --minify -o jsonpath='{..namespace}']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Command output: ['']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Running command: [kubectl config view --minify -o jsonpath='{..namespace}']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Command output: ['']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Running command: [kubectl config view --minify -o jsonpath='{..namespace}']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Command output: ['']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Running command: [kubectl config view --minify -o jsonpath='{..namespace}']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Command output: ['']" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="CLI platforms provided: \"\"" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="platform detection from active kubernetes cluster is not enabled" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="Using builder: local" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="push value not present in NewBuilder, defaulting to false because cluster.PushImages is false" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=info msg="build concurrency set to default value of -1" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=info msg="Tags generated in 0s" subtask=-1 task=Build
time="2023-01-04T23:50:05-06:00" level=info msg="Starting render..." subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=info msg="starting render process" subtask=0 task=Render
time="2023-01-04T23:50:05-06:00" level=debug msg="Executing template &{envTemplate 0xc000d26240 0xc000a9e050 } with environment map[ALLUSERSPROFILE:C:\\ProgramData APPDATA:C:\\Users\\waj33\\AppData\\Roaming CLion:C:\\Program Files\\JetBrains\\CLion 2022.2.3\\bin; COMPUTERNAME:DESKTOP-0C0TBOE ChocolateyInstall:C:\\ProgramData\\chocolatey ChocolateyLastPathUpdate:133098096135588322 ComSpec:C:\\WINDOWS\\system32\\cmd.exe CommonProgramFiles:C:\\Program Files\\Common Files CommonProgramFiles(x86):C:\\Program Files (x86)\\Common Files CommonProgramW6432:C:\\Program Files\\Common Files DriverData:C:\\Windows\\System32\\Drivers\\DriverData FX3_INSTALL_PATH:C:\\Program Files (x86)\\Cypress\\EZ-USB FX3 SDK\\1.3\\ GOPATH:C:\\Users\\waj33\\go GoLand:C:\\Program Files\\JetBrains\\GoLand 2021.2.3\\bin; HOMEDRIVE:C: HOMEPATH:\\Users\\waj33 INTEL_DEV_REDIST:C:\\Program Files (x86)\\Common Files\\Intel\\Shared Libraries\\ IntelliJ IDEA:C:\\Program Files\\JetBrains\\IntelliJ IDEA 2021.2.3\\bin; LOCALAPPDATA:C:\\Users\\waj33\\AppData\\Local LOGONSERVER:\\\\DESKTOP-0C0TBOE MIC_LD_LIBRARY_PATH:C:\\Program Files (x86)\\Common Files\\Intel\\Shared Libraries\\compiler\\lib\\mic NUMBER_OF_PROCESSORS:24 OS:Windows_NT OneDrive:C:\\Users\\waj33\\OneDrive OneDriveConsumer:C:\\Users\\waj33\\OneDrive PATHEXT:.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.CPL PROCESSOR_ARCHITECTURE:AMD64 PROCESSOR_IDENTIFIER:AMD64 Family 23 Model 113 Stepping 0, AuthenticAMD PROCESSOR_LEVEL:23 PROCESSOR_REVISION:7100 PSModulePath:C:\\Users\\waj33\\OneDrive\\Documents\\WindowsPowerShell\\Modules;C:\\Program Files\\WindowsPowerShell\\Modules;C:\\WINDOWS\\system32\\WindowsPowerShell\\v1.0\\Modules;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\platform\\PowerShell PUBLIC:C:\\Users\\Public Path:C:\\Program Files (x86)\\Razer\\ChromaBroadcast\\bin;C:\\Program Files\\Razer\\ChromaBroadcast\\bin;C:\\Program Files\\Common Files\\Oracle\\Java\\javapath;C:\\Program Files (x86)\\Common Files\\Intel\\Shared Libraries\\redist\\intel64\\compiler;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\Windows\\System32\\OpenSSH\\;C:\\Program Files (x86)\\NVIDIA Corporation\\PhysX\\Common;C:\\devtools;C:\\flutter\\flutter\\bin;C:\\Program Files (x86)\\Google\\Cloud SDK\\google-cloud-sdk\\bin;C:\\ProgramData\\chocolatey\\bin;C:\\devtools\\apache-maven-3.8.3\\bin;C:\\devtools\\gradle-6.9.1\\bin;C:\\Program Files\\NVIDIA Corporation\\NVIDIA NvDLISR;C:\\Program Files\\dotnet\\;C:\\Windows\\system32\\config\\systemprofile\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Program Files\\Git\\cmd;C:\\Program Files\\Go\\bin;C:\\Program Files\\PuTTY\\;C:\\Program Files (x86)\\Arm GNU Toolchain arm-none-eabi\\12.2 mpacbti-bet1\\bin;C:\\Program Files (x86)\\Arm GNU Toolchain arm-none-eabi\\12.2 mpacbti-bet1\\arm-none-eabi\\bin;C:\\Program Files\\CMake\\bin;C:\\WINDOWS\\system32;C:\\WINDOWS;C:\\WINDOWS\\System32\\Wbem;C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\;C:\\WINDOWS\\System32\\OpenSSH\\;C:\\Program Files\\Kubernetes\\Minikube;;C:\\Program Files\\Docker\\Docker\\resources\\bin;C:\\Users\\waj33\\.cargo\\bin;C:\\Users\\waj33\\Projects\\tinygo\\build;C:\\xpack-openocd-0.11.0-5\\bin;C:\\Users\\waj33\\AppData\\Local\\Programs\\Python\\Python310\\;C:\\Users\\waj33\\AppData\\Local\\Microsoft\\WindowsApps;C:\\Program Files\\JetBrains\\GoLand 2021.2.3\\bin;C:\\Program Files\\JetBrains\\IntelliJ IDEA 2021.2.3\\bin;C:\\Users\\waj33\\AppData\\Local\\Pub\\Cache\\bin;C:\\Users\\waj33\\AppData\\Local\\Android\\Sdk\\platform-tools;C:\\Infineon\\LauncherService;C:\\Users\\waj33\\go\\bin;C:\\Program Files\\JetBrains\\CLion 2022.2.3\\bin;C:\\Users\\waj33\\AppData\\Local\\Programs\\Microsoft VS Code\\bin;C:\\ProgramData\\chocolatey\\lib\\mingw\\tools\\install\\mingw64\\bin;C:\\Program Files\\Git\\usr\\bin ProgramData:C:\\ProgramData ProgramFiles:C:\\Program Files ProgramFiles(x86):C:\\Program Files (x86) ProgramW6432:C:\\Program Files SystemDrive:C: SystemRoot:C:\\WINDOWS TEMP:C:\\Users\\waj33\\AppData\\Local\\Temp TMP:C:\\Users\\waj33\\AppData\\Local\\Temp USERDOMAIN:DESKTOP-0C0TBOE USERDOMAIN_ROAMINGPROFILE:DESKTOP-0C0TBOE USERNAME:waj33 USERPROFILE:C:\\Users\\waj33 WSLENV:WT_SESSION::WT_PROFILE_ID WT_PROFILE_ID:{61c54bbd-c2c6-5271-96e7-009a87ff44bf} WT_SESSION:4436f41f-b9e7-46ed-a1e3-489e11186c4c windir:C:\\WINDOWS]" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=debug msg="manifests with tagged images:apiVersion: v1\nkind: Secret\nmetadata:\n name: super-secret-secret\n namespace: test\n---\ndata:\n password: c3VwZXJzZWN1cmVwYXNzd29yZA\n---\napiVersion: v1\nkind: Pod" subtask=0 task=Render
time="2023-01-04T23:50:05-06:00" level=debug msg="manifests set with namespace apiVersion: v1\nkind: Secret\nmetadata:\n name: super-secret-secret\n namespace: test\n---\ndata:\n password: c3VwZXJzZWN1cmVwYXNzd29yZA\n---\napiVersion: v1\nkind: Pod\nmetadata:\n namespace: default" subtask=-1 task=DevLoop
time="2023-01-04T23:50:05-06:00" level=info msg="Render completed in 1.5779ms" subtask=-1 task=DevLoop
apiVersion: v1
kind: Secret
metadata:
name: super-secret-secret
namespace: test
---
data:
password: c3VwZXJzZWN1cmVwYXNzd29yZA
---
apiVersion: v1
kind: Pod
metadata:
namespace: default
```
Contributor guide
Assessment
This issue has not been assessed yet.