GoogleContainerTools / GoogleContainerTools/skaffold

Add validation around the required values for setValueTemplates artifact names (eg: no `.`, `/`, or `-`)

Open
#8,277 0 comments 0 reactions 0 assignees View on GitHub
kind/todo
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

As stated in https://skaffold.dev/docs/pipeline-stages/deployers/helm/#sanitizing-the-artifact-name-from-invalid-go-template-characters, setValueTemplates proper usage requires changing all `.`, `-`, and `/` charts -> `_`. We should add validation around the required values for setValueTemplates artifact names (eg: no `.`, `/`, or `-`) so that users aren't confused/know-this and don't accidentally misconfigures skaffold or have friction here

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.