GoogleContainerTools / GoogleContainerTools/skaffold

Not possible to add custom labels to kaniko pods

Open
#8,193 0 comments 7 reactions 0 assignees View on GitHub
build/kaniko kind/bug priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

https://github.com/GoogleContainerTools/skaffold/blob/88a27ab9f81f337fa0fe4207aa829f632a01787e/pkg/skaffold/build/cluster/pod.go#L56

We are using AKS + ACR with managed identity, so in order to allow pods to access ACR we mark them with label "aad-pod-identity: ", since kaniko pods doesn't allow to set custom labels we are not able to use images from our custom registry.

Current behavior: Kaniko pod labels are always set to "skaffold-kaniko"
Expected behavior: it is possible to pass custom labels to kaniko pods

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.