GoogleContainerTools / GoogleContainerTools/skaffold

[testing] - integrations/examples/buildx erroring for `Verify examples` tests

Open
#7,962 1 comment 0 reactions 0 assignees View on GitHub
area/multi-platform kind/todo meta/testing priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

Currently there is a `Verify examples` test that runs changes examples when files are changed in integration/examples/*. It seems that currently the `integration/examples/custom-buildx` is broken when run via `Verify examples` but it only run when this example is modified:
```
>> integration/examples/custom-buildx
Generating tags...
- skaffold-examples-buildx -> skaffold-examples-buildx:latest
Starting build...
multi-platform build requires pushing images to a valid container registry. To run multi-platform builds, set --push to true and set a container registry with --default-repo or in the global config.
Error: Process completed with exit code 1.
```

It seems the root cause is that multi-platform builds require pushing an image but the test itself goes through a path that does not push the image:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.