GoogleContainerTools / GoogleContainerTools/skaffold
Investigate refactoring `EvalBuildArgs` and `EvalBuildArgsWithEnv`
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
A recent contibutor @0xADD1E noted that there is likely an opportunity to refactor how our build args work -
> It does feel like there should be a more elegant way of doing this, particularly with the caching bits (perhaps using EvalBuildArgsWithEnv everywhere? That's not how Kaniko is doing it though) -- but I don't think I have a complete enough picture to know exactly what that would be.
https://github.com/GoogleContainerTools/skaffold/pull/7788#issuecomment-1231963464
I agree that there seems to be some inconsitencies in how there are used in different builders which prompted - https://github.com/GoogleContainerTools/skaffold/pull/7788
Tracking this work here.
Contributor guide
Assessment
This issue has not been assessed yet.