GoogleContainerTools / GoogleContainerTools/skaffold

Triggered actionable error is not showing the proper message

Open
#7,790 0 comments 0 reactions 0 assignees View on GitHub
kind/bug kind/todo priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior
When an actionable error is triggered, that is not wrap inside an `error` type, the action text associated with it should be shown as part of the error.

### Actual behavior
Instead, only the error message appears in the error.

### Information
- Skaffold version: v2.0.0-beta1-33-gf30cf99c0
- Operating system: MacOS
- Installed via: local build

### Steps to reproduce the behavior
1. From the source code, trigger an Actionable error, without wrapping it inside an `error` type
2. In the console, once the Actionable error appears, only the error message is shown, the action text associated with it does not appear

It looks like in https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/errors/errors.go#L90, in the `ShowAIError` function, we are unwrapping the error once, so, if we return an Actionable error directly, we are not able to recognize it with the proper type.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.