GoogleContainerTools / GoogleContainerTools/skaffold

Skaffold should output a more clear message when deployStatus check exceeds the timelimit

Open
#7,680 0 comments 0 reactions 0 assignees View on GitHub
area/eventing area/status-check kind/feature-request priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior
- when deployStatusCheck exceeds the time limit, skaffold logs should show something like status check failed

### Actual behavior
- skaffold logs shows that deployment failed

Log:
```bash
Generating tags...
- skaffold-example -> skaffold-example:v1.38.0-145-g75eabca67-dirty
Checking cache...
- skaffold-example: Found Locally
Starting test...
Tags used in deployment:
- skaffold-example -> skaffold-example:0d72cf6042a04559e8664cb46c1d46d3c2dec8da2e33899f382cf2432e9fd604
Starting deploy...
- pod/getting-started configured
Waiting for deployments to stabilize...
1/1 deployment(s) failed

```

### Information

- Skaffold version: v2 main
- Operating system: MacOS
- Installed via:
- Contents of skaffold.yaml:

```yaml
apiVersion: skaffold/v2beta29
kind: Config
build:
artifacts:
- image: skaffold-example
deploy:
kubeContext: "minikube"
statusCheckDeadlineSeconds: 1
kubectl:
manifests:
- k8s-*
```

### Steps to reproduce the behavior

1. in example/getting-started project run ``skaffold run`` command with the above yaml file should be able to see deployment failed .
2. run kubectl get pod.. should be able to seeing that the pod is actually running.. not failed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.