GoogleContainerTools / GoogleContainerTools/skaffold

investigate + implement decoupling legacy helm deployer to use the helm renderer

Open
#7,607 1 comment 0 reactions 1 assignee Claimed by @renzodavid9 View on GitHub
kind/todo priority/p2
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

Currently in Skaffold V2 @ HEAD, skaffold has 2 "modes" for helm that require different schema configurations:

- helm renderer + kubectl deployer schema config
```
TODO
```

- legacy helm deployer
```
TODO
```

while this is likely somewhat confusing to users writing this schemas themselves (as to which to use and the difference between them), skaffold fix currently only supports generating schemas with the legacy helm deployer syntax.

This issue tracks possibly changing the LegacyHelmDeploy to take information from the `manifests` field and potentially work more similarly to a `Deployer` vs a `Renderer+Deployer`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.