GoogleContainerTools / GoogleContainerTools/skaffold

Status Check throws error when deploying a statefulset with OnDelete update strategy

Open
#7,589 3 comments 0 reactions 0 assignees View on GitHub
area/status-check kind/enhancement priority/p3
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

### Expected behavior

For statefulsets with the `updateStrategy` set to `OnDelete` the status check should be skipped.

### Actual behavior

Skaffold attempts to perform a status check via the `rollout status statefulset` command which is not supported.

### Information

- Skaffold version: 1.38.0
- Operating system: Linux
- Installed via: skaffold.dev
- Deployer: Helm

### Steps to reproduce the behavior

1. Deploy any helm chart that contains a statefulset with OnDelete strategy

### Logs

```
Release "foo-backend" has been upgraded. Happy Helming!
NAME: foo-backend
LAST DEPLOYED: Sun Jun 26 09:29:49 2022
NAMESPACE: foo-dev
STATUS: deployed
REVISION: 537
TEST SUITE: None
Waiting for deployments to stabilize...
- foo-dev:deployment/tsdb is ready. [10/11 deployment(s) still pending]
- foo-dev:statefulset/jsreport is ready. [9/11 deployment(s) still pending]
- foo-dev:deployment/foo-backend-jaeger-collector is ready. [8/11 deployment(s) still pending]
- foo-dev:deployment/dataingress is ready. [7/11 deployment(s) still pending]
- foo-dev:statefulset/foo-backend-cassandra: running [kubectl --context kstg-stg --namespace foo-dev rollout status statefulset foo-backend-cassandra --namespace foo-dev --watch=false]
- stdout: ""
- stderr: "error: rollout status is only available for RollingUpdate strategy type\n"
- cause: exit status 1
- foo-dev:statefulset/foo-backend-cassandra failed. Error: running [kubectl --context kstg-stg --namespace foo-dev rollout status statefulset foo-backend-cassandra --namespace foo-dev --watch=false]
- stdout: ""
- stderr: "error: rollout status is only available for RollingUpdate strategy type\n"
- cause: exit status 1.
1/11 deployment(s) failed
make: *** [Makefile:33: dev] Error 1
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.