GoogleContainerTools / GoogleContainerTools/skaffold

Feature-Request: Ability to toggle on/off (or a new default, or option to switch w/ SkaffoldLogEntry) which exports ApplicationLogEvents into the LogFile

Open
#7,280 1 comment 0 reactions 0 assignees View on GitHub
area/eventing area/logging kind/feature-request priority/p2 source/partnerships
Dominant language
Go
Stars
15.9k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

Currently skaffold outputs the SkaffoldLogEvent entry into the files exported via the `--event-log-files=logs.txt` flag. There is a feature request to use this file to populate log information for containers/deployments but currently such a page would have redundant information as the logs themselves a prefix indicated their source:

example:
```
{"timestamp":"2022-04-07T21:27:36.492114957Z","skaffoldLogEvent":{"taskId":"DevLoop-1","subtaskId":"-1","level":"STANDARD","message":"\u001b[92m[ernie] \u001b[0mHey there Bert!\n"}}
```

^^^ has a green `[ernie]` prefix to indicate the source container but this is not desirable. The application logs event would not have this which is desired

Some possible solutins would be:
- a flag (--log-application-log-events-to-events-file) which adds the desired events there (which don't have this prefix) in addition to SkaffoldLogEvents
- a new default adding these events there as well (might be too reduntant, break tools not expecting this event)
- a flag (--log-application-log-events-to-events-file) to switch SkaffoldLogEntry events w/ ApplicationLogEntry events in the file

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.