GoogleContainerTools / GoogleContainerTools/skaffold
Fix skaffold logic to not assume 10m means "unset" for `Deployment.spec.progressDeadlineSeconds`
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
Currently skaffold `statusCheckDeadlineSeconds` and `deployment.Spec.ProgressDeadlineSeconds` logic which assumes that a 10m value being set fo `d.Spec.ProgressDeadlineSeconds` means it is unset. This is because hosted GKE providers use this value so skaffold treats this as unset. To support the possibility that a user sets this to 10m, it might make sense to instead see if it is set in the yaml vs using this value as a proxy for that:
https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/kubernetes/status/status_check.go#L307-L311
```
if d.Spec.ProgressDeadlineSeconds == nil || *d.Spec.ProgressDeadlineSeconds == kubernetesMaxDeadline {
deadline = deadlineDuration
} else {
deadline = time.Duration(*d.Spec.ProgressDeadlineSeconds) * time.Second
}
```
Contributor guide
Assessment
This issue has not been assessed yet.