GoogleContainerTools / GoogleContainerTools/skaffold
kubectl and kpt deployers should warn of unused images
- Dominant language
- Go
- Stars
- 15.9k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 10
Description
Following on
- #7240
The Helm deployer warns when the user attempts to deploy with images that are not referenced in the Helm charts:
https://github.com/GoogleContainerTools/skaffold/blob/1471f8af56a7977ce2621957b96e66598016bc1b/pkg/skaffold/deploy/helm/deploy.go#L670-L677
But this functionality in the Helm deployer is disabled for multi-configs:
https://github.com/GoogleContainerTools/skaffold/blob/1471f8af56a7977ce2621957b96e66598016bc1b/pkg/skaffold/deploy/helm/deploy.go#L270-L272
Proposal:
- We should extend this behaviour to the kubectl and kpt deployers.
- Have the deployers return the list of referenced images so that this check can be performed in the top-level Skaffold regardless of whether the deployment is single- or multi-config.
Contributor guide
Assessment
This issue has not been assessed yet.